abstractdog commented on code in PR #461:
URL: https://github.com/apache/tez/pull/461#discussion_r2884078034
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -2415,13 +2416,15 @@ public static void main(String[] args) {
// Install the tez class loader, which can be used add new resources
TezClassLoader.setupTezClassLoader();
Thread.setDefaultUncaughtExceptionHandler(new
YarnUncaughtExceptionHandler());
- final String pid = System.getenv().get("JVM_PID");
Review Comment:
while I like using ProcessHandle instead of `JVM_PID`, I'm not sure if this
is 100% correct
I'm concerned by the fact that `JVM_PID` is used in yarn too, see in hadoop
code, e.g.
https://github.com/apache/hadoop/blob/f49c49aa083b9324ae432902f94a7aaf98f543ea/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/YarnChild.java#L126
also, not 100% sure if JVM_PID belongs to the actual Java process id or the
`launch_container.sh` shell script provided by yarn: even if the shell script
must be the parent of the jvm process, they are not the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
