abstractdog commented on code in PR #473:
URL: https://github.com/apache/tez/pull/473#discussion_r3490403163
##########
tez-api/src/main/java/org/apache/tez/dag/api/TezConfiguration.java:
##########
@@ -2420,4 +2423,12 @@ static Set<String> getPropertySet() {
@ConfigurationScope(Scope.AM)
@ConfigurationProperty
public static final String TEZ_AM_STANDALONE_CONFS = TEZ_AM_PREFIX +
"standalone.confs";
+
+ /**
+ * String value. Namespace in ZooKeeper registry for the TezChild
+ */
+ @ConfigurationScope(Scope.VERTEX)
+ @ConfigurationProperty
+ public static final String TEZ_TASK_REGISTRY_NAMESPACE = TEZ_TASK_PREFIX +
"registry.namespace";
+ public static final String TEZ_TASK_REGISTRY_NAMESPACE_DEFAULT =
"/tez_am/workers";
Review Comment:
`/tez-am/workers` looks a bit strange, a component is an `am` or a `worker`
##########
tez-api/src/main/java/org/apache/tez/dag/api/TezConfiguration.java:
##########
@@ -2420,4 +2423,12 @@ static Set<String> getPropertySet() {
@ConfigurationScope(Scope.AM)
@ConfigurationProperty
public static final String TEZ_AM_STANDALONE_CONFS = TEZ_AM_PREFIX +
"standalone.confs";
+
+ /**
+ * String value. Namespace in ZooKeeper registry for the TezChild
+ */
+ @ConfigurationScope(Scope.VERTEX)
+ @ConfigurationProperty
+ public static final String TEZ_TASK_REGISTRY_NAMESPACE = TEZ_TASK_PREFIX +
"registry.namespace";
+ public static final String TEZ_TASK_REGISTRY_NAMESPACE_DEFAULT =
"/tez_am/workers";
Review Comment:
`/tez-am/workers` looks a bit strange, a component is an `am` or a `worker`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
