Aggarwal-Raghav commented on code in PR #473:
URL: https://github.com/apache/tez/pull/473#discussion_r3503938534
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/FetcherOrderedGrouped.java:
##########
@@ -180,7 +180,7 @@ public FetcherOrderedGrouped(HttpConnectionParams
httpConnectionParams,
@VisibleForTesting
protected void fetchNext() throws InterruptedException, IOException {
try {
- if (localDiskFetchEnabled && mapHost.getHost().equals(localShuffleHost)
&& mapHost.getPort() == localShufflePort) {
Review Comment:
Also this jar is explicitly excluded from tez-dist where tez_shuffle is
present 🤔
As there is no NodeManager going forward, So, requirement for tez_shuffle is
required. Am I missing something?
https://github.com/apache/tez/blob/1d66b76bc91f1c1274d36c26d362a31aca7d0f75/tez-dist/src/main/assembly/tez-dist.xml#L26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]