Aggarwal-Raghav commented on code in PR #473:
URL: https://github.com/apache/tez/pull/473#discussion_r3503879217
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/FetcherOrderedGrouped.java:
##########
@@ -180,7 +180,7 @@ public FetcherOrderedGrouped(HttpConnectionParams
httpConnectionParams,
@VisibleForTesting
protected void fetchNext() throws InterruptedException, IOException {
try {
- if (localDiskFetchEnabled && mapHost.getHost().equals(localShuffleHost)
&& mapHost.getPort() == localShufflePort) {
Review Comment:
I was not aware that tez shuffle handler class needs to be configured in
YARN for YARN MODE. I checked in my prod as well, its not configured for
tez-0.10.x? Something new i learnt.
Why tez is not pointing to tez_shuffle by default
```
public static final String TEZ_AM_SHUFFLE_AUXILIARY_SERVICE_ID_DEFAULT =
"mapreduce_shuffle";
```
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/ShuffleUtils.java:
##########
@@ -316,6 +316,9 @@ static ByteBuffer generateDMEPayload(boolean
sendEmptyPartitionDetails,
if (!sendEmptyPartitionDetails || outputGenerated) {
String host = context.getExecutionContext().getHostName();
+ if (host == null) {
Review Comment:
ACK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
