rawlinp commented on a change in pull request #2785: In Traffic Router Support
Snapshots which only update Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239962607
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManager.java
##########
@@ -285,38 +336,43 @@ public StatTracker getStatTracker() {
return createZoneCache(cacheType, CacheBuilderSpec.parse(""));
}
- private static LoadingCache<ZoneKey, Zone> createZoneCache(final
ZoneCacheType cacheType, final CacheBuilderSpec spec) {
+ private static LoadingCache<ZoneKey, Zone> createZoneCache(final
ZoneCacheType cacheType,
+ final
CacheBuilderSpec spec) {
final RemovalListener<ZoneKey, Zone> removalListener = new
RemovalListener<ZoneKey, Zone>() {
public void onRemoval(final
RemovalNotification<ZoneKey, Zone> removal) {
- LOGGER.debug(cacheType + " " +
removal.getKey().getClass().getSimpleName() + " " + removal.getKey().getName()
+ " evicted from cache: " + removal.getCause());
+ LOGGER.debug(cacheType + " " +
removal.getKey().getClass().getSimpleName() + " " + removal.getKey()
+ .getName() + " evicted from
cache: " + removal.getCause());
}
};
return
CacheBuilder.from(spec).recordStats().removalListener(removalListener).build(
- new CacheLoader<ZoneKey, Zone>() {
- final boolean writeZone = (cacheType ==
ZoneCacheType.STATIC) ? true : false;
+ new CacheLoader<ZoneKey, Zone>() {
Review comment:
in the future please refrain from doing massive whitespace changes like
this; it's difficult to review with other non-whitespace changes. If you'd like
to change/improve so much formatting, please do so in a separate,
formatting-only PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
