rawlinp commented on a change in pull request #2785: In Traffic Router Support
Snapshots which only update Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239932659
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/config/CertificateChecker.java
##########
@@ -67,19 +70,18 @@ public boolean hasCertificate(final List<CertificateData>
certificateDataList, f
.isPresent();
}
- @SuppressWarnings("PMD.CyclomaticComplexity")
- private boolean deliveryServiceHasValidCertificates(final
List<CertificateData> certificateDataList, final JsonNode deliveryServicesJson,
final String deliveryServiceId) {
- final JsonNode deliveryServiceJson =
deliveryServicesJson.get(deliveryServiceId);
- final JsonNode protocolJson =
deliveryServiceJson.get("protocol");
+ @SuppressWarnings("PMD.CyclomaticComplexity")
+ private Boolean deliveryServiceHasValidCertificates(final
List<CertificateData> certificateDataList, final DeliveryService
deliveryService) {
+ final String deliveryServiceId = deliveryService.getId();
- if (!supportsHttps(deliveryServiceJson, protocolJson)) {
- return true;
+ if (!supportsHttps(deliveryService)) {
+ return true;
Review comment:
indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
