rawlinp commented on a change in pull request #2785: In Traffic Router Support
Snapshots which only update Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r239933601
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/config/ConfigHandler.java
##########
@@ -15,63 +15,72 @@
package com.comcast.cdn.traffic_control.traffic_router.core.config;
-import java.io.IOException;
-import java.net.UnknownHostException;
-import java.net.URL;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Date;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.TreeSet;
-import java.util.Iterator;
-import java.util.concurrent.BlockingQueue;
-import java.util.concurrent.atomic.AtomicBoolean;
-import java.util.stream.Collectors;
-
+import com.comcast.cdn.traffic_control.traffic_router.core.cache.Cache;
+import
com.comcast.cdn.traffic_control.traffic_router.core.cache.Cache.DeliveryServiceReference;
+import com.comcast.cdn.traffic_control.traffic_router.core.cache.CacheLocation;
+import com.comcast.cdn.traffic_control.traffic_router.core.cache.CacheRegister;
+import com.comcast.cdn.traffic_control.traffic_router.core.ds.DeliveryService;
+import
com.comcast.cdn.traffic_control.traffic_router.core.ds.DeliveryServiceMatcher;
+import
com.comcast.cdn.traffic_control.traffic_router.core.ds.DeliveryServiceMatcher.Type;
import com.comcast.cdn.traffic_control.traffic_router.core.ds.SteeringWatcher;
+import com.comcast.cdn.traffic_control.traffic_router.core.loc.AnonymousIp;
+import
com.comcast.cdn.traffic_control.traffic_router.core.loc.AnonymousIpConfigUpdater;
+import
com.comcast.cdn.traffic_control.traffic_router.core.loc.AnonymousIpDatabaseUpdater;
+import
com.comcast.cdn.traffic_control.traffic_router.core.loc.DeepNetworkUpdater;
import
com.comcast.cdn.traffic_control.traffic_router.core.loc.FederationsWatcher;
import
com.comcast.cdn.traffic_control.traffic_router.core.loc.GeolocationDatabaseUpdater;
import com.comcast.cdn.traffic_control.traffic_router.core.loc.NetworkNode;
import com.comcast.cdn.traffic_control.traffic_router.core.loc.NetworkUpdater;
-import
com.comcast.cdn.traffic_control.traffic_router.core.loc.DeepNetworkUpdater;
import
com.comcast.cdn.traffic_control.traffic_router.core.loc.RegionalGeoUpdater;
-
+import
com.comcast.cdn.traffic_control.traffic_router.core.monitor.TrafficMonitorWatcher;
+import com.comcast.cdn.traffic_control.traffic_router.core.request.HTTPRequest;
+import com.comcast.cdn.traffic_control.traffic_router.core.router.StatTracker;
+import
com.comcast.cdn.traffic_control.traffic_router.core.router.TrafficRouterManager;
import
com.comcast.cdn.traffic_control.traffic_router.core.secure.CertificatesPoller;
import
com.comcast.cdn.traffic_control.traffic_router.core.secure.CertificatesPublisher;
import com.comcast.cdn.traffic_control.traffic_router.core.util.JsonUtils;
import
com.comcast.cdn.traffic_control.traffic_router.core.util.JsonUtilsException;
+import
com.comcast.cdn.traffic_control.traffic_router.core.util.TrafficOpsUtils;
+import com.comcast.cdn.traffic_control.traffic_router.geolocation.Geolocation;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.apache.log4j.Logger;
-import com.comcast.cdn.traffic_control.traffic_router.core.cache.Cache;
-import com.comcast.cdn.traffic_control.traffic_router.core.cache.CacheLocation;
-import com.comcast.cdn.traffic_control.traffic_router.core.cache.CacheRegister;
-import
com.comcast.cdn.traffic_control.traffic_router.core.cache.Cache.DeliveryServiceReference;
-import com.comcast.cdn.traffic_control.traffic_router.core.ds.DeliveryService;
-import
com.comcast.cdn.traffic_control.traffic_router.core.ds.DeliveryServiceMatcher;
-import
com.comcast.cdn.traffic_control.traffic_router.core.ds.DeliveryServiceMatcher.Type;
-import
com.comcast.cdn.traffic_control.traffic_router.core.monitor.TrafficMonitorWatcher;
-import
com.comcast.cdn.traffic_control.traffic_router.core.router.TrafficRouterManager;
-import
com.comcast.cdn.traffic_control.traffic_router.core.util.TrafficOpsUtils;
-import com.comcast.cdn.traffic_control.traffic_router.core.router.StatTracker;
-import com.comcast.cdn.traffic_control.traffic_router.geolocation.Geolocation;
-import com.comcast.cdn.traffic_control.traffic_router.core.request.HTTPRequest;
-import com.comcast.cdn.traffic_control.traffic_router.core.loc.AnonymousIp;
-import
com.comcast.cdn.traffic_control.traffic_router.core.loc.AnonymousIpConfigUpdater;
-import
com.comcast.cdn.traffic_control.traffic_router.core.loc.AnonymousIpDatabaseUpdater;
+import java.io.IOException;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.net.UnknownHostException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.TreeSet;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.function.Predicate;
+import java.util.stream.Collectors;
@SuppressWarnings("PMD.TooManyFields")
public class ConfigHandler {
private static final Logger LOGGER =
Logger.getLogger(ConfigHandler.class);
private static long lastSnapshotTimestamp = 0;
- private static Object configSync = new Object();
- private static String deliveryServicesKey = "deliveryServices";
+ private static final Object configSync = new Object();
+ final static String contentServersKey = "contentServers";
Review comment:
Can you capitalize+snake case these constants names to make it more obvious
they're constants?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
