rob05c commented on a change in pull request #3104: Add monitoring.json
snapshotting
URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240294906
##########
File path: traffic_ops/traffic_ops_golang/crconfig/snapshot.go
##########
@@ -40,10 +42,14 @@ func Snapshot(tx *sql.Tx, crc *tc.CRConfig) error {
if crc.Stats.DateUnixSeconds != nil {
date = time.Unix(*crc.Stats.DateUnixSeconds, 0)
}
+
+ tm, _ := monitoring.GetMonitoringJSON(tx, *crc.Stats.CDNName)
Review comment:
It seems a little odd that this func takes the `CRConfig` as a parameter,
but gets the Monitoring JSON itself. It'd be more consistent, and also more
flexible, for this to take the Monitoring JSON as a parameter too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
