rob05c commented on a change in pull request #3104: Add monitoring.json 
snapshotting
URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240293991
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/crconfig/snapshot.go
 ##########
 @@ -27,9 +27,11 @@ import (
 
        "github.com/apache/trafficcontrol/lib/go-log"
        "github.com/apache/trafficcontrol/lib/go-tc"
+       
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/monitoring"
 )
 
 // Snapshot takes the CRConfig JSON-serializable object (which may be 
generated via crconfig.Make), and writes it to the snapshot table.
+// It also takes the monitoring config JSON and writes it to the snapshot table
 
 Review comment:
   Nitpick: GoDoc comment should be a complete sentence, missing a period at 
the end.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to