rob05c commented on a change in pull request #3104: Add monitoring.json
snapshotting
URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r241073292
##########
File path: traffic_ops/traffic_ops_golang/crconfig/snapshot.go
##########
@@ -27,10 +27,12 @@ import (
"github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/lib/go-tc"
+
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/monitoring"
)
// Snapshot takes the CRConfig JSON-serializable object (which may be
generated via crconfig.Make), and writes it to the snapshot table.
-func Snapshot(tx *sql.Tx, crc *tc.CRConfig) error {
+// It also takes the monitoring config JSON and writes it to the snapshot
table.
+func Snapshot(tx *sql.Tx, crc *tc.CRConfig, monitoringJson
*monitoring.Monitoring) error {
Review comment:
Nitpick: Go initialisms should be consistent-cased, should be
`monitoringJSON`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
