mitchell852 commented on a change in pull request #3758: Rewrote
deliveryservice_stats to Go
URL: https://github.com/apache/trafficcontrol/pull/3758#discussion_r307884885
##########
File path: traffic_ops/traffic_ops_golang/routing/routes.go
##########
@@ -104,6 +105,9 @@ func Routes(d ServerData) ([]Route, []RawRoute,
http.Handler, error) {
{1.1, http.MethodPost, `asns/?$`,
api.CreateHandler(&asn.TOASNV11{}), auth.PrivLevelOperations, Authenticated,
nil},
{1.1, http.MethodDelete, `asns/{id}$`,
api.DeleteHandler(&asn.TOASNV11{}), auth.PrivLevelOperations, Authenticated,
nil},
+ // Traffic Stats access
+ {1.2, http.MethodGet, `deliveryservice_stats`,
trafficstats.GetDSStats, auth.PrivLevelOperations, Authenticated, nil},
Review comment:
is operations really the role enforced in Perl? seems high. I would think as
long as tenancy is checked, readonly is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
