mitchell852 commented on a change in pull request #3758: Rewrote
deliveryservice_stats to Go
URL: https://github.com/apache/trafficcontrol/pull/3758#discussion_r307914912
##########
File path: traffic_ops/traffic_ops_golang/routing/routes.go
##########
@@ -104,6 +105,9 @@ func Routes(d ServerData) ([]Route, []RawRoute,
http.Handler, error) {
{1.1, http.MethodPost, `asns/?$`,
api.CreateHandler(&asn.TOASNV11{}), auth.PrivLevelOperations, Authenticated,
nil},
{1.1, http.MethodDelete, `asns/{id}$`,
api.DeleteHandler(&asn.TOASNV11{}), auth.PrivLevelOperations, Authenticated,
nil},
+ // Traffic Stats access
+ {1.2, http.MethodGet, `deliveryservice_stats`,
trafficstats.GetDSStats, auth.PrivLevelOperations, Authenticated, nil},
Review comment:
> Alphabetical organization might be dangerous
oh yeah, i forgot. there are some in there that are very order dependent.
but if adding a `d` one, might as well put it next to the `d`s imo. kinda
sucks that they can't be alphabetized somehow, gives me a headache searching
thru for stuff that i forgot the name to.
at the very least. seems like they could all be grouped somehow. i.e. all
the ds related routes are grouped together. maybe something to tackle later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
