mattjackson220 commented on a change in pull request #4339: 
cachegroupparameters rewrite
URL: https://github.com/apache/trafficcontrol/pull/4339#discussion_r373586890
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/cachegroupparameter/parameters.go
 ##########
 @@ -180,3 +185,124 @@ func (cgparam *TOCacheGroupParameter) Delete() (error, 
error, int) {
 
        return api.GenericDelete(cgparam)
 }
+
+// ReadAllCacheGroupParameters reads all cachegroup parameter associations.
+func ReadAllCacheGroupParameters(w http.ResponseWriter, r *http.Request) {
+       inf, userErr, sysErr, errCode := api.NewInfo(r, nil, nil)
+       if userErr != nil || sysErr != nil {
+               api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+               return
+       }
+       defer inf.Close()
+       output, err := GetAllCacheGroupParameters(inf.Tx.Tx)
+       if err != nil {
+               api.WriteRespAlertObj(w, r, tc.ErrorLevel, "querying 
cachegroupparameters with error: "+err.Error(), output)
+               return
+       }
+       api.WriteResp(w, r, output)
+}
+
+// GetAllCacheGroupParameters gets all cachegroup associations from the 
database and returns as slice.
+func GetAllCacheGroupParameters(tx *sql.Tx) (tc.CacheGroupParametersList, 
error) {
+       parameters := map[string]string{
+               "orderby": "cachegroup",
 
 Review comment:
   i was thinking to mirror the perl endpoint better but added it back in as 
well as docs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to