mhoppa commented on a change in pull request #4339: cachegroupparameters rewrite
URL: https://github.com/apache/trafficcontrol/pull/4339#discussion_r373654216
##########
File path: traffic_ops/client/cachegroup_parameters.go
##########
@@ -67,6 +67,24 @@ func (to *Session) getCacheGroupParameters(route,
queryParams string) ([]tc.Cach
return data.Response, reqInf, nil
}
+// GetAllCacheGroupParameters Gets all Cachegroup Parameter associations
+func (to *Session) GetAllCacheGroupParameters()
([]tc.CacheGroupParametersResponseNullable, ReqInf, error) {
+ route := fmt.Sprintf("%s/", API_v1_CacheGroupParameters)
+ r := fmt.Sprintf("%s/%s", route, "")
Review comment:
wont this turn out as `cachegroupparameters//` I dont think you need to
format it twice. I dont think this is a bug but more of clean up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
