mattjackson220 commented on a change in pull request #4339: 
cachegroupparameters rewrite
URL: https://github.com/apache/trafficcontrol/pull/4339#discussion_r373589613
 
 

 ##########
 File path: traffic_ops/client/cachegroup_parameters.go
 ##########
 @@ -67,6 +67,28 @@ func (to *Session) getCacheGroupParameters(route, 
queryParams string) ([]tc.Cach
        return data.Response, reqInf, nil
 }
 
+// GetAllCacheGroupParameters Gets all Cachegroup Parameter associations
+func (to *Session) GetAllCacheGroupParameters() 
([]tc.CacheGroupParametersResponseNullable, ReqInf, error) {
+       route := fmt.Sprintf("%s/", API_v1_CacheGroupParameters)
+       return to.getAllCacheGroupParameters(route, "")
+}
+
+func (to *Session) getAllCacheGroupParameters(route, queryParams string) 
([]tc.CacheGroupParametersResponseNullable, ReqInf, error) {
 
 Review comment:
   oh originally i was going to mirror the get methods above but realized i 
only needed the one but left it split even though the second one isnt reused. 
ill combine them again since theres no need for 2

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to