rawlinp commented on a change in pull request #4724:
URL: https://github.com/apache/trafficcontrol/pull/4724#discussion_r444519499
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/edge/CacheRegister.java
##########
@@ -129,6 +130,12 @@ public void setCacheMap(final Map<String,Cache> map) {
return allCaches;
}
+ public Set<DeliveryServiceMatcher> getDeliveryServiceMatchers(final
DeliveryService deliveryService) {
+ return this.deliveryServiceMatchers.stream()
+ .filter(deliveryServiceMatcher ->
deliveryServiceMatcher.getDeliveryService() == deliveryService)
Review comment:
Do you purposely mean to compare the references here using `==` rather
than `getDeliveryService().getId().equals(deliveryService.getId())` to compare
the xml_id?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
