rawlinp commented on a change in pull request #4724:
URL: https://github.com/apache/trafficcontrol/pull/4724#discussion_r444533031
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/ds/DeliveryService.java
##########
@@ -76,13 +77,19 @@
@JsonIgnore
private final String domain;
@JsonIgnore
+ private final String tld;
+ @JsonIgnore
+ private final Pattern wildcardPattern =
Pattern.compile("^\\(\\.\\*\\\\\\.\\|\\^\\)|^\\.\\*\\\\\\.|\\\\\\.\\.\\*");
Review comment:
Just looking at this I can't tell what the _actual_ regex is supposed to
be with all these escaping backslashes. Can you include a comment that includes
the unescaped version of the regex?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
