zrhoffman commented on a change in pull request #4724:
URL: https://github.com/apache/trafficcontrol/pull/4724#discussion_r444563736
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/edge/CacheRegister.java
##########
@@ -129,6 +130,12 @@ public void setCacheMap(final Map<String,Cache> map) {
return allCaches;
}
+ public Set<DeliveryServiceMatcher> getDeliveryServiceMatchers(final
DeliveryService deliveryService) {
+ return this.deliveryServiceMatchers.stream()
+ .filter(deliveryServiceMatcher ->
deliveryServiceMatcher.getDeliveryService() == deliveryService)
Review comment:
Nope! Comparing xml_ids in 1f9d31e444.
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/ds/DeliveryService.java
##########
@@ -76,13 +77,19 @@
@JsonIgnore
private final String domain;
@JsonIgnore
+ private final String tld;
+ @JsonIgnore
+ private final Pattern wildcardPattern =
Pattern.compile("^\\(\\.\\*\\\\\\.\\|\\^\\)|^\\.\\*\\\\\\.|\\\\\\.\\.\\*");
Review comment:
Included a comment that explains an unescaped version of the regex in
067427f975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
