rob05c commented on a change in pull request #4790:
URL: https://github.com/apache/trafficcontrol/pull/4790#discussion_r465822582
##########
File path: lib/go-atscfg/meta.go
##########
@@ -146,24 +151,64 @@ func AddMetaObjConfigDir(
log.Errorln("meta config generation got Delivery
Service with nil XMLID - not considering!")
continue
}
+
err := error(nil)
// Note we log errors, but don't return them.
// If an individual DS has an error, we don't want to break the
rest of the CDN.
- if (ds.EdgeHeaderRewrite != nil || ds.MaxOriginConnections !=
nil) &&
- strings.HasPrefix(server.Type, tc.EdgeTypePrefix) {
- fileName := "hdr_rw_" + *ds.XMLID + ".config"
- scope := tc.ATSConfigMetaDataConfigFileScopeCDNs
- if configFilesM, err = ensureConfigFile(configFilesM,
fileName, configDir, scope); err != nil {
- log.Errorln("meta config generation: " +
err.Error())
+ if ds.Topology != nil && *ds.Topology != "" {
+ topology := tc.Topology{}
+ for _, to := range topologies {
+ if to.Name == *ds.Topology {
+ topology = to
+ break
+ }
}
Review comment:
I went back and forth whether to use a map for these. The performance
doesn't matter, unless someone had on the order of a million topologies, the
network cost vastly outweighs this. But I don't really object, I'll change them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
