rob05c commented on a change in pull request #4790:
URL: https://github.com/apache/trafficcontrol/pull/4790#discussion_r465868702
##########
File path: traffic_ops_ort/atstccfg/config/config.go
##########
@@ -297,4 +297,8 @@ type TOData struct {
// SSLKeys must be all the ssl keys for the server's cdn.
SSLKeys []tc.CDNSSLKeys
+
+ // Topologies must be all the topologies for the server's cdn.
+ // May incude topologies of other cdns.
+ Topologies []tc.Topology
Review comment:
I'd like to keep TOData as the raw data from Traffic Ops, in order to
make the config gen library `lib/go-atscfg` more flexible.
As soon as the config routes are removed from TO, the plan is to change
`lib/go-atscfg` to take standard API objects.
If we do pre-processing like putting things in maps in ORT/atstccfg, and
pass pre-processed data to `lib/go-atscfg`, then `atscfg` is harder to use for
anyone wanting to just make a TO request for the necessary data and pass it to
a config gen func.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
