[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #4934: Validating absolute DNS name requirement on Static DNS Entry Type

Fri, 07 Aug 2020 11:18:26 -0700 


rimashah25 commented on a change in pull request #4934:
URL: https://github.com/apache/trafficcontrol/pull/4934#discussion_r467198001



##########
File path: docs/source/api/v3/staticdnsentries.rst
##########
@@ -234,7 +234,7 @@ Request Structure
        |  id  | The integral, unique identifier of the static DNS entry to 
modify |
        
+------+-------------------------------------------------------------------+
 
-:address:           If ``typeId`` identifies a ``CNAME`` type record, this is 
the Canonical Name (CNAME) of the server, otherwise it is the IP address to 
which ``host`` shall be resolved
+:address:           If ``typeId`` identifies a ``CNAME`` type record, this is 
the Canonical Name (CNAME) of the server that is required to end with a 
trailing period (eg:cdn.test.com. is right usage but cdn.test.com will throw an 
error), otherwise it is the IP address to which ``host`` shall be resolved

Review comment:
       > also, there are 4 types, right?
   > 
   > 
![image](https://user-images.githubusercontent.com/251272/89673576-d4391100-d8a3-11ea-90a1-e946a0ca5b00.png)
   > 
   > are there any rules for TXT_RECORD? if so, want to add it to your tooltip?
   > 
   > 
![image](https://user-images.githubusercontent.com/251272/89673532-c7b4b880-d8a3-11ea-9629-fca88d1ba1fe.png)
   
   Code updated to reflect TXT_RECORD




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to