rimashah25 commented on a change in pull request #4934:
URL: https://github.com/apache/trafficcontrol/pull/4934#discussion_r467197613
##########
File path:
traffic_portal/test/end_to_end/deliveryServices/delivery-services-spec.js
##########
@@ -327,6 +331,30 @@ describe('Traffic Portal Delivery Services Suite',
function() {
});
});
+ it('should add a required Static DNS entry to the HTTP delivery
service', function() {
+ pageData.dsLink.click();
+ console.log('Adding Static DNS entry to ' + mockVals.httpXmlId);
+ pageData.moreBtn.click();
+ pageData.viewStaticCapabilitiesMenuItem.click();
+
expect(browser.getCurrentUrl().then(commonFunctions.urlPath)).toMatch(commonFunctions.urlPath(browser.baseUrl)+"#!/delivery-services/[0-9]+/static-dns-entries");
+ pageData.addStaticDNSBtn.click();
+ //
expect(pageData.selectFormSubmitButton.isEnabled()).toBe(false);
+ // set host name
+ pageData.host.sendKeys(mockVals.staticDNShostName);
+ // set type ID
Review comment:
Code updated.
##########
File path:
traffic_portal/test/end_to_end/deliveryServices/delivery-services-spec.js
##########
@@ -327,6 +331,30 @@ describe('Traffic Portal Delivery Services Suite',
function() {
});
});
+ it('should add a required Static DNS entry to the HTTP delivery
service', function() {
+ pageData.dsLink.click();
+ console.log('Adding Static DNS entry to ' + mockVals.httpXmlId);
+ pageData.moreBtn.click();
+ pageData.viewStaticCapabilitiesMenuItem.click();
+
expect(browser.getCurrentUrl().then(commonFunctions.urlPath)).toMatch(commonFunctions.urlPath(browser.baseUrl)+"#!/delivery-services/[0-9]+/static-dns-entries");
+ pageData.addStaticDNSBtn.click();
+ //
expect(pageData.selectFormSubmitButton.isEnabled()).toBe(false);
Review comment:
Code updated.
##########
File path: traffic_portal/test/end_to_end/deliveryServices/pageData.js
##########
@@ -37,6 +39,10 @@ module.exports = function(){
this.protocol=element(by.name('protocol'));
this.longDesc=element(by.name('longDesc'));
this.remapText=element(by.name('remapText'));
+ this.host=element(by.name('host'));
Review comment:
Code updated.
##########
File path: traffic_portal/test/end_to_end/deliveryServices/pageData.js
##########
@@ -37,6 +39,10 @@ module.exports = function(){
this.protocol=element(by.name('protocol'));
this.longDesc=element(by.name('longDesc'));
this.remapText=element(by.name('remapText'));
+ this.host=element(by.name('host'));
+ this.typeId=element(by.name('typeId'));
Review comment:
Code updated.
##########
File path: docs/source/api/v3/staticdnsentries.rst
##########
@@ -234,7 +234,7 @@ Request Structure
| id | The integral, unique identifier of the static DNS entry to
modify |
+------+-------------------------------------------------------------------+
-:address: If ``typeId`` identifies a ``CNAME`` type record, this is
the Canonical Name (CNAME) of the server, otherwise it is the IP address to
which ``host`` shall be resolved
+:address: If ``typeId`` identifies a ``CNAME`` type record, this is
the Canonical Name (CNAME) of the server that is required to end with a
trailing period (eg:cdn.test.com. is right usage but cdn.test.com will throw an
error), otherwise it is the IP address to which ``host`` shall be resolved
Review comment:
> also, there are 4 types, right?
>
>
>
> are there any rules for TXT_RECORD? if so, want to add it to your tooltip?
>
>
Code updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
