srijeet0406 commented on a change in pull request #5011:
URL: https://github.com/apache/trafficcontrol/pull/5011#discussion_r485748925
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/router/TrafficRouter.java
##########
@@ -513,8 +514,9 @@ public Geolocation getLocation(final String clientIP, final
DeliveryService deli
}
}
- if (clientLocation.isDefaultLocation() &&
defaultGeolocationsOverride.containsKey(clientLocation.getCountryCode())) {
- clientLocation =
defaultGeolocationsOverride.get(clientLocation.getCountryCode());
+ if (clientLocation.isDefaultLocation() &&
getDefaultGeoLocationsOverride().containsKey(clientLocation.getCountryCode())) {
+ clientLocation = deliveryService.getMissLocation();
Review comment:
Yeah that will be a part of the change that I proposed last night on the
mailing list. I was just waiting to see if there were any concerns with that.
I'll make the changes today 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
