mattjackson220 commented on a change in pull request #5011:
URL: https://github.com/apache/trafficcontrol/pull/5011#discussion_r488185211



##########
File path: 
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/router/StatTracker.java
##########
@@ -184,7 +184,13 @@ public void setRegionalAlternateCount(final int 
regionalAlternateCount) {
                        /**
                         * This value indicates that routing was blocked in 
accordance with anonymous blocking configurations.
                         */
-                       ANON_BLOCK
+                       ANON_BLOCK,
+                       /**
+                        * This value indicates that routing was based on the 
default lat/long of the delivery service, because maxmind
+                        * returned the centre of the country as the client 
location, due to the CZF not being able to resolve the client IP
+                        * to a valid location.
+                        */
+                       GEO_DS

Review comment:
       do you think there would be any gain to add another result type that let 
us know that it is just using the default from maxmind (like if it doesnt have 
a DS default and the client ip didnt resolve to a valid location)? not sure if 
theres any gain there but might just give us more info quickly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to