mattjackson220 commented on a change in pull request #5011:
URL: https://github.com/apache/trafficcontrol/pull/5011#discussion_r488184275
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/router/TrafficRouter.java
##########
@@ -523,7 +530,11 @@ public Geolocation getLocation(final String clientIP,
final DeliveryService deli
track.setResultDetails(ResultDetails.GEO_NO_CACHE_FOUND);
}
- track.setResult(ResultType.GEO);
+ if (useDSDefaults) {
Review comment:
would this be able to go into the if statement above? instead of having
the useDSDefaults boolean just set the result type in that if statement
instead? then we could get rid of the SuppressWarnings too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
