rawlinp commented on a change in pull request #5345:
URL: https://github.com/apache/trafficcontrol/pull/5345#discussion_r535714365
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -172,11 +174,12 @@ type DeliveryServiceV11 struct {
type DeliveryServiceNullableV30 struct {
DeliveryServiceNullableV15
- Topology *string `json:"topology" db:"topology"`
- FirstHeaderRewrite *string `json:"firstHeaderRewrite"
db:"first_header_rewrite"`
- InnerHeaderRewrite *string `json:"innerHeaderRewrite"
db:"inner_header_rewrite"`
- LastHeaderRewrite *string `json:"lastHeaderRewrite"
db:"last_header_rewrite"`
- ServiceCategory *string `json:"serviceCategory"
db:"service_category"`
+ Topology *string `json:"topology" db:"topology"`
+ FirstHeaderRewrite *string `json:"firstHeaderRewrite"
db:"first_header_rewrite"`
+ InnerHeaderRewrite *string `json:"innerHeaderRewrite"
db:"inner_header_rewrite"`
+ LastHeaderRewrite *string `json:"lastHeaderRewrite"
db:"last_header_rewrite"`
+ ServiceCategory *string `json:"serviceCategory"
db:"service_category"`
+ MaxRequestHeaderSize *int `json:"maxRequestHeaderSize"
db:"max_request_header_size"`
Review comment:
Since 5.0 is leaving the station, we probably need a new
`DeliveryServiceNullableV31` struct and all the other changes that come with
that, since this will likely be 3.1. Right @ocket8888? This shouldn't be
backported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
