rawlinp commented on a change in pull request #5345:
URL: https://github.com/apache/trafficcontrol/pull/5345#discussion_r536204900
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -172,11 +174,12 @@ type DeliveryServiceV11 struct {
type DeliveryServiceNullableV30 struct {
DeliveryServiceNullableV15
- Topology *string `json:"topology" db:"topology"`
- FirstHeaderRewrite *string `json:"firstHeaderRewrite"
db:"first_header_rewrite"`
- InnerHeaderRewrite *string `json:"innerHeaderRewrite"
db:"inner_header_rewrite"`
- LastHeaderRewrite *string `json:"lastHeaderRewrite"
db:"last_header_rewrite"`
- ServiceCategory *string `json:"serviceCategory"
db:"service_category"`
+ Topology *string `json:"topology" db:"topology"`
+ FirstHeaderRewrite *string `json:"firstHeaderRewrite"
db:"first_header_rewrite"`
+ InnerHeaderRewrite *string `json:"innerHeaderRewrite"
db:"inner_header_rewrite"`
+ LastHeaderRewrite *string `json:"lastHeaderRewrite"
db:"last_header_rewrite"`
+ ServiceCategory *string `json:"serviceCategory"
db:"service_category"`
+ MaxRequestHeaderSize *int `json:"maxRequestHeaderSize"
db:"max_request_header_size"`
Review comment:
He's referring to
https://github.com/apache/trafficcontrol/blob/master/blueprints/ds-active.md
which hasn't been started yet. That blueprint would call for a major version
bump.
_This_ PR could add it as 3.1, then if we get to ☝️ before 5.1 is released,
that API could still be added as 4.0. Then 3.1 == 4.0 like how 1.5 == 2.0 (if
that makes sense). It _would_ be cleaner if we were able to have just one or
the other, but I don't think it's a big deal if we end up having to add both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
