rawlinp commented on a change in pull request #5345:
URL: https://github.com/apache/trafficcontrol/pull/5345#discussion_r535716468
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
##########
@@ -858,6 +859,7 @@ func updateV30(w http.ResponseWriter, r *http.Request, inf
*api.APIInfo, ds *tc.
&ds.InnerHeaderRewrite,
&ds.LastHeaderRewrite,
&ds.ServiceCategory,
+ &ds.MaxRequestHeaderSize,
Review comment:
The way the DS API works, we also need to query the existing value of
`max_request_header_size` in `updateV15`, in order for 1.5 requests to be
properly _upgraded_ to 3.0 requests. Otherwise, a pre-3.0 request would blow
away the existing value.
The
[README](https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/README.md#updating-a-minor-version)
explains this a bit better, but might be out of date now that
`DeliveryServiceNullable` is deprecated :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
