ocket8888 commented on a change in pull request #5209:
URL: https://github.com/apache/trafficcontrol/pull/5209#discussion_r575474674
##########
File path: traffic_ops/build/traffic_ops.spec
##########
@@ -206,23 +203,16 @@ if [ "$1" = "0" ]; then
# this is an uninstall
%__rm -rf %{PACKAGEDIR}
%__rm /etc/init.d/traffic_ops
- /usr/bin/getent passwd %{TRAFFIC_OPS_USER} || /usr/sbin/userdel
%{TRAFFIC_OPS_USER}
- /usr/bin/getent group %{TRAFFIC_OPS_GROUP} ||
/usr/sbin/groupdel %{TRAFFIC_OPS_GROUP}
+ /usr/bin/getent passwd %{TRAFFIC_OPS_USER} || /usr/sbin/userdel
%{TRAFFIC_OPS_USER}
+ /usr/bin/getent group %{TRAFFIC_OPS_GROUP} || /usr/sbin/groupdel
%{TRAFFIC_OPS_GROUP}
fi
%files
%license ../LICENSE
%defattr(644,root,root,755)
-%attr(755,%{TRAFFIC_OPS_USER},%{TRAFFIC_OPS_GROUP})
%{PACKAGEDIR}/app/bin/config2json
-%attr(755,%{TRAFFIC_OPS_USER},%{TRAFFIC_OPS_GROUP})
%{PACKAGEDIR}/app/bin/extensions
-%attr(755,%{TRAFFIC_OPS_USER},%{TRAFFIC_OPS_GROUP})
%{PACKAGEDIR}/app/bin/osversions-convert.pl
-%attr(755,%{TRAFFIC_OPS_USER},%{TRAFFIC_OPS_GROUP})
%{PACKAGEDIR}/app/bin/routes.pl
-%attr(755,%{TRAFFIC_OPS_USER},%{TRAFFIC_OPS_GROUP})
%{PACKAGEDIR}/app/bin/start.pl
%attr(755,%{TRAFFIC_OPS_USER},%{TRAFFIC_OPS_GROUP})
%{PACKAGEDIR}/app/bin/traffic_ops_golang
-%attr(755,%{TRAFFIC_OPS_USER},%{TRAFFIC_OPS_GROUP})
%{PACKAGEDIR}/app/script/cdn
%attr(755,%{TRAFFIC_OPS_USER},%{TRAFFIC_OPS_GROUP})
%{PACKAGEDIR}/app/script/detect10ginterfaces.pl
Review comment:
I don't think we should, those scripts might still be in use. The `cdn`
script was deleted because it was the entrypoint for Traffic Ops Perl - or one
of them, anyway. I think there were like 3 ways to start it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
