ocket8888 commented on a change in pull request #5922:
URL: https://github.com/apache/trafficcontrol/pull/5922#discussion_r648740923
##########
File path: lib/go-tc/deliveryservices.go
##########
@@ -192,18 +194,416 @@ type DeliveryServiceFieldsV31 struct {
// DeliveryServiceV40 is a Delivery Service as it appears in version 4.0 of the
// Traffic Ops API.
type DeliveryServiceV40 struct {
- DeliveryServiceFieldsV31
- DeliveryServiceFieldsV30
- DeliveryServiceFieldsV15
- DeliveryServiceFieldsV14
- DeliveryServiceFieldsV13
- DeliveryServiceNullableFieldsV11
+ // Active dictates whether the Delivery Service is routed by Traffic
Router.
+ Active bool `json:"active" db:"active"`
Review comment:
in a handler in TO you can, but then if it's a PUT or POST you need to
check again after reading from the database. And utility functions that don't
know the contexts in which they might be used need to check, and client methods
need to check before access, and code using the clients needs to check before
access on the responses, and it needs to get checked ad nauseum in testing
code. It's a giant pain that Go won't let you just say "if it's missing this
property, throw an error". That would solve so many problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
