ocket8888 commented on a change in pull request #5922:
URL: https://github.com/apache/trafficcontrol/pull/5922#discussion_r651795083
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
##########
@@ -416,88 +546,100 @@ func createV40(w http.ResponseWriter, r *http.Request,
inf *api.APIInfo, dsV40 t
if err != nil {
usrErr, sysErr, code := api.ParseDBError(err)
- return nil, code, usrErr, sysErr
+ return nil, alerts, code, usrErr, sysErr
}
defer resultRows.Close()
id := 0
- lastUpdated := tc.TimeNoMod{}
+ var lastUpdated time.Time
Review comment:
Specifically, the change on this line fixes typing. A `tc.TimeNoMod`
value is not assignable to `time.Time` - although you could extract the nested
time instead, I think this is clearer.
As to why/whether that's necessary, we're discussing that on your second
comment in this review above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
