ocket8888 commented on a change in pull request #5922:
URL: https://github.com/apache/trafficcontrol/pull/5922#discussion_r651786548
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/safe.go
##########
@@ -94,17 +94,39 @@ func UpdateSafe(w http.ResponseWriter, r *http.Request) {
ds := dses[0]
alertMsg := "Delivery Service safe update successful."
- if inf.Version != nil && inf.Version.Major == 1 && inf.Version.Minor <
5 {
- switch inf.Version.Minor {
+ if inf.Version == nil {
+ log.Warnln("API version found to be null in DS safe update")
+ api.WriteRespAlertObj(w, r, tc.SuccessLevel, alertMsg, dses)
Review comment:
no, that would skip writing the changelog message below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
