zrhoffman commented on a change in pull request #6026:
URL: https://github.com/apache/trafficcontrol/pull/6026#discussion_r673475299
##########
File path: .github/workflows/tp.integration.tests.yml
##########
@@ -119,4 +119,10 @@ jobs:
path: ${{ github.workspace
}}/traffic_portal/test/integration/Reports/
- name: Save Alpine Docker image
run: .github/actions/save-alpine-tar/entrypoint.sh save ${{
env.ALPINE_VERSION }}
-
+ - name: Check Go Version
+ run: echo "::set-output name=value::$(cat GO_VERSION)"
+ id: go-version
+ - name: Install Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: ${{ steps.go-version.outputs.value }}
Review comment:
Missing a newline at the end of `tp.integration.tests.yml`
##########
File path: .github/workflows/check-go-modules.yml
##########
@@ -58,3 +56,10 @@ jobs:
- name: Changes to go.sum
if: ${{ steps.vendor-dependencies.outcome == 'success' && always() }}
run: .github/actions/check-go-modules/entrypoint.sh check_go_file
go.sum
+ - name: Check Go Version
+ run: echo "::set-output name=value::$(cat GO_VERSION)"
+ id: go-version
+ - name: Install Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: ${{ steps.go-version.outputs.value }}
Review comment:
Setting up Go needs to come before the *Vendor dependencies* step
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
