zrhoffman commented on a change in pull request #6026:
URL: https://github.com/apache/trafficcontrol/pull/6026#discussion_r674944443
##########
File path: .github/workflows/traffic-ops.yml
##########
@@ -121,3 +121,10 @@ jobs:
smtp_address: 172.17.0.1
- name: Save Alpine Docker image
run: .github/actions/save-alpine-tar/entrypoint.sh save ${{
env.ALPINE_VERSION }}
+ - name: Check Go Version
+ run: echo "::set-output name=value::$(cat GO_VERSION)"
+ id: go-version
+ - name: Install Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: ${{ steps.go-version.outputs.value }}
Review comment:
Installing Go needs to come before the *Run API v1 tests* step.
##########
File path: .github/workflows/tp.integration.tests.yml
##########
@@ -119,4 +119,10 @@ jobs:
path: ${{ github.workspace
}}/traffic_portal/test/integration/Reports/
- name: Save Alpine Docker image
run: .github/actions/save-alpine-tar/entrypoint.sh save ${{
env.ALPINE_VERSION }}
-
+ - name: Check Go Version
+ run: echo "::set-output name=value::$(cat GO_VERSION)"
+ id: go-version
+ - name: Install Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: ${{ steps.go-version.outputs.value }}
Review comment:
Installing Go needs to come before the *Run TP* step.
##########
File path: infrastructure/ansible/roles/traffic_portal/defaults/main.yml
##########
@@ -196,7 +196,7 @@ tp_default_properties_template:
customLink:
_comment: Do you want to show a custom link to your own ds
dashboards?
show: false
- baseUrl: "{{ tp_ts_base_url
}}/dashboard/script/traffic_ops_deliveryservice.js?which="
+ baseUrl: "{{ tp_ts_base_url }}/dashboard/db/cdn-overview?var-svc="
Review comment:
The Delivery Service Grafana dashboard URL change still needs to be
reverted.
##########
File path: infrastructure/ansible/roles/traffic_portal/defaults/main.yml
##########
@@ -208,7 +208,7 @@ tp_default_properties_template:
_comment: Do you want to show a charts button for each server? If so,
where
can the charts be found? xml id will be appended to the provided url.
show: false
- baseUrl: "{{ tp_ts_base_url
}}/dashboard/script/traffic_ops_server.js?which="
+ baseUrl: "{{ tp_ts_base_url }}/dashboard/db/server-stats?var-SERVER="
Review comment:
The Server Grafana dashboard URL change still needs to be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
