zrhoffman commented on code in PR #6802:
URL: https://github.com/apache/trafficcontrol/pull/6802#discussion_r876393032
##########
traffic_ops/app/db/create_tables.sql:
##########
@@ -143,6 +143,42 @@ LANGUAGE plpgsql;
Review Comment:
* `admin` user is missing some capability:
```diff
@@ -1,7 +1,4 @@
1 ALL A_TIMESTAMP
-1 DNS-SEC:DELETE A_TIMESTAMP
-1 DNS-SEC:READ A_TIMESTAMP
-1 PARAMETER-SECURE:READ A_TIMESTAMP
2 ASN:READ A_TIMESTAMP
2 ASYNC-STATUS:READ A_TIMESTAMP
2 CACHE-GROUP:READ A_TIMESTAMP
```
* `read-only` is missing a role:
```diff
@@ -63,7 +60,6 @@
3 CDN-SNAPSHOT:READ A_TIMESTAMP
3 COORDINATE:READ A_TIMESTAMP
3 DELIVERY-SERVICE:READ A_TIMESTAMP
-3 DELIVERY-SERVICE-SAFE:UPDATE A_TIMESTAMP
3 DIVISION:READ A_TIMESTAMP
3 DS-REQUEST:READ A_TIMESTAMP
3 DS-SECURITY-KEY:READ A_TIMESTAMP
```
##########
traffic_ops/app/db/create_tables.sql:
##########
@@ -143,6 +143,42 @@ LANGUAGE plpgsql;
Review Comment:
* `admin` user is missing some capability:
```diff
@@ -1,7 +1,4 @@
1 ALL A_TIMESTAMP
-1 DNS-SEC:DELETE A_TIMESTAMP
-1 DNS-SEC:READ A_TIMESTAMP
-1 PARAMETER-SECURE:READ A_TIMESTAMP
2 ASN:READ A_TIMESTAMP
2 ASYNC-STATUS:READ A_TIMESTAMP
2 CACHE-GROUP:READ A_TIMESTAMP
```
* `read-only` is missing a capability:
```diff
@@ -63,7 +60,6 @@
3 CDN-SNAPSHOT:READ A_TIMESTAMP
3 COORDINATE:READ A_TIMESTAMP
3 DELIVERY-SERVICE:READ A_TIMESTAMP
-3 DELIVERY-SERVICE-SAFE:UPDATE A_TIMESTAMP
3 DIVISION:READ A_TIMESTAMP
3 DS-REQUEST:READ A_TIMESTAMP
3 DS-SECURITY-KEY:READ A_TIMESTAMP
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
