ocket8888 commented on code in PR #6802:
URL: https://github.com/apache/trafficcontrol/pull/6802#discussion_r879825150


##########
traffic_ops/app/db/trafficvault/migrations/2021042200000000_init.up.sql:
##########
@@ -1,16 +0,0 @@
-/*

Review Comment:
   It actually breaks if there are no migrations in that directory. Which may 
explain why the init up and down migrations for Traffic Vault were just
   ```sql
   SELECT;
   ```
   I think it would be better to fix the test to not worry about the case that 
there are no migrations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to