zrhoffman commented on code in PR #6802:
URL: https://github.com/apache/trafficcontrol/pull/6802#discussion_r878587708


##########
traffic_ops/app/db/create_tables.sql:
##########
@@ -143,6 +143,42 @@ LANGUAGE plpgsql;
 

Review Comment:
   > Wait, those `DNS-SEC:*` Permissions are coming from a migration that 
hasn't been squashed. The only way they could be missing is if you didn't run 
migrations, had a pre-existing Role with the name `admin` that has a priv_level 
under 30, or modified the database after you were done using 
`github.com/apache/trafficcontrol/traffic_ops/app/db/admin`.
   
   While you are right that those perms are being added in a migration, the 
migrations are definitely being run, because I am using the `db/admin` tool to 
do it (see 
https://github.com/apache/trafficcontrol/pull/6802#issuecomment-1133448159 for 
the script I am using).
   
   From my testing, the failure for those perms to exist once those migrations 
are run does seem to be a result of the squash in #6802.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to