ocket8888 commented on code in PR #7036:
URL: https://github.com/apache/trafficcontrol/pull/7036#discussion_r956323645
##########
traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js:
##########
@@ -119,6 +119,15 @@ var FormDeliveryServiceController =
function(deliveryService, dsCurrent, origin,
}
$scope.validateTLS = validateTLS;
+ let getSteeringTargets = function() {
Review Comment:
2 Questions: a) why the `let varName= functionExpression` instead of
`function functionName ... `?
And also, why not make this a bit cleaner by making function `async"?
##########
experimental/traffic-portal/src/app/api/delivery-service.service.ts:
##########
@@ -158,6 +159,17 @@ export class DeliveryServiceService extends APIService {
this.deliveryServiceTypes = new Array<Type>();
}
+ public async getSteering(): Promise<Array<SteeringConfiguration>>;
Review Comment:
This overload is redundant, because the call signature is identical to that
of the implementation
##########
experimental/traffic-portal/src/app/api/testing/delivery-service.service.ts:
##########
@@ -167,6 +168,16 @@ export class DeliveryServiceService {
}
];
+ public async getSteering(): Promise<Array<SteeringConfiguration>>;
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
