shamrickus commented on code in PR #7036:
URL: https://github.com/apache/trafficcontrol/pull/7036#discussion_r961034826
##########
traffic_portal/app/src/common/service/utils/DeliveryServiceUtils.js:
##########
@@ -17,45 +17,61 @@
* under the License.
*/
-var DeliveryServiceUtils = function($window, propertiesModel) {
-
- this.protocols = {
- 0: "HTTP",
- 1: "HTTPS",
- 2: "HTTP AND HTTPS",
- 3: "HTTP TO HTTPS"
- };
-
- this.qstrings = {
- 0: "USE",
- 1: "IGNORE",
- 2: "DROP"
- };
-
- this.geoProviders = {
- 0: "MaxMind",
- 1: "Neustar"
- };
-
- this.geoLimits = {
- 0: "None",
- 1: "CZF Only",
- 2: "CZF + Country Code(s)",
- };
-
- this.rrhs = {
- 0: "no cache",
- 1: "background_fetch",
- 2: "cache_range_requests",
- 3: "slice"
- };
-
- this.openCharts = function(ds) {
- $window.open(
-
propertiesModel.properties.deliveryServices.charts.customLink.baseUrl +
ds.xmlId,
- '_blank'
- );
- };
+var DeliveryServiceUtils = function ($window, propertiesModel) {
+
+ this.protocols = {
+ 0: "HTTP",
+ 1: "HTTPS",
+ 2: "HTTP AND HTTPS",
+ 3: "HTTP TO HTTPS"
+ };
+
+ this.qstrings = {
+ 0: "USE",
+ 1: "IGNORE",
+ 2: "DROP"
+ };
+
+ this.geoProviders = {
+ 0: "MaxMind",
+ 1: "Neustar"
+ };
+
+ this.geoLimits = {
+ 0: "None",
+ 1: "CZF Only",
+ 2: "CZF + Country Code(s)",
+ };
+
+ this.rrhs = {
+ 0: "no cache",
+ 1: "background_fetch",
+ 2: "cache_range_requests",
+ 3: "slice"
Review Comment:
Thought I had my editor set to tabs for js so I just assumed it converted
them to tabs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
