ocket8888 commented on code in PR #7036:
URL: https://github.com/apache/trafficcontrol/pull/7036#discussion_r961318010
##########
traffic_portal/app/src/common/service/utils/DeliveryServiceUtils.js:
##########
@@ -17,45 +17,61 @@
* under the License.
*/
-var DeliveryServiceUtils = function($window, propertiesModel) {
-
- this.protocols = {
- 0: "HTTP",
- 1: "HTTPS",
- 2: "HTTP AND HTTPS",
- 3: "HTTP TO HTTPS"
- };
-
- this.qstrings = {
- 0: "USE",
- 1: "IGNORE",
- 2: "DROP"
- };
-
- this.geoProviders = {
- 0: "MaxMind",
- 1: "Neustar"
- };
-
- this.geoLimits = {
- 0: "None",
- 1: "CZF Only",
- 2: "CZF + Country Code(s)",
- };
-
- this.rrhs = {
- 0: "no cache",
- 1: "background_fetch",
- 2: "cache_range_requests",
- 3: "slice"
- };
-
- this.openCharts = function(ds) {
- $window.open(
-
propertiesModel.properties.deliveryServices.charts.customLink.baseUrl +
ds.xmlId,
- '_blank'
- );
- };
+var DeliveryServiceUtils = function ($window, propertiesModel) {
+
+ this.protocols = {
+ 0: "HTTP",
+ 1: "HTTPS",
+ 2: "HTTP AND HTTPS",
+ 3: "HTTP TO HTTPS"
+ };
+
+ this.qstrings = {
+ 0: "USE",
+ 1: "IGNORE",
+ 2: "DROP"
+ };
+
+ this.geoProviders = {
+ 0: "MaxMind",
+ 1: "Neustar"
+ };
+
+ this.geoLimits = {
+ 0: "None",
+ 1: "CZF Only",
+ 2: "CZF + Country Code(s)",
+ };
+
+ this.rrhs = {
+ 0: "no cache",
+ 1: "background_fetch",
+ 2: "cache_range_requests",
+ 3: "slice"
Review Comment:
now THAT I would've gotten behind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
