zrhoffman commented on code in PR #7298:
URL: https://github.com/apache/trafficcontrol/pull/7298#discussion_r1080801830
##########
infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile:
##########
@@ -71,9 +71,11 @@ COPY ./infrastructure/cdn-in-a-box/traffic_ops/to-access.sh
/opt/integration/app
COPY ./infrastructure/cdn-in-a-box/traffic_ops_integration_test/config.sh
/opt/integration/app/
COPY ./traffic_ops/testing/api/v3/tc-fixtures.json
/opt/integration/app/tc-fixtures-v3.json
COPY ./traffic_ops/testing/api/v4/tc-fixtures.json
/opt/integration/app/tc-fixtures-v4.json
+COPY ./traffic_ops/testing/api/v5/tc-fixtures.json
/opt/integration/app/tc-fixtures-v5.json
COPY --from=integration-builder \
/go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api/traffic_ops_v3_integration_test
\
/go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api/traffic_ops_v4_integration_test
\
+
/go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api/traffic_ops_v5_integration_test
\
Review Comment:
Good catch, that's been a lot of missing test coverage not running the v5
API tests when running from CiaB until now
##########
infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile:
##########
@@ -46,7 +46,7 @@ WORKDIR
/go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api
RUN go mod vendor -v
RUN set -o errexit -o xtrace;\
- for api_version in v3 v4; do\
+ for api_version in v3 v4 v5; do\
Review Comment:
`v3 v4 v5` can be `v{3..5}` like
https://github.com/apache/trafficcontrol/blob/e9616117a52277f6d28bfee12873496d68e1ecae/infrastructure/cdn-in-a-box/traffic_ops_integration_test/run.sh#L45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
