zrhoffman commented on PR #7298: URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397743743
> One thing Zach didn't mention: according to what I'm seeing here, the lib tests only run if code in the lib changes. But that library is linked to from, I think, every other Go component. So when lib changes, we need to run ALL of those tests, not just the lib tests. Also, things that depend on the Go client need to be re-tested when the Go client changes. I'm actually not sure that we're doing that today - but if not it's a gap in testing that should be closed. Looks like this is addressed, would you mind re-reviewing (and merging, if it's ready) @ocket8888? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
