ericholguin commented on PR #7298:
URL: https://github.com/apache/trafficcontrol/pull/7298#issuecomment-1397379289

   > What is the goal of splitting the Go unit tests into components?
   
   Since we'd like to run all the unit tests regardless of files modified, the 
only goal would be to have separated badges, GitHub actions only have one badge 
per workflow, hence they all need a separate workflow. The value gain is that 
you'll be able to see which specific unit test failed at a glance without 
needing to click into the whole workflow. Also it would allow for Codecov 
badges to be added alongside to each of the unit workflow badges, showing the 
coverage for each unit tests and not the coverage as a whole.
   
   > Also, we shouldn't only run _some_ unit tests on a given PR, we should run 
all unit tests every time, which we can do because unit tests are almost always 
fast.
   
   Agreed, will fix that
   
   > If you feel strongly that we would still benefit from splitting them up by 
component, though, that could be done more succinctly using a GHA 
[matrix](https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs)
 strategy. That way, we would still only need 1 workflow, even though it would 
still show up 6 times in the list of GHAs run.
   
   Again, the badge workflow issue, will explore if there is an alternative
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to