shamrickus opened a new pull request, #7303: URL: https://github.com/apache/trafficcontrol/pull/7303
<!-- Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md If this closes or relates to an existing issue, please reference it using one of the following: Closes: #ISSUE Related: #ISSUE If this PR fixes a security vulnerability, DO NOT submit! Instead, contact the Apache Traffic Control Security Team at secur...@trafficcontrol.apache.org and follow the guidelines at https://apache.org/security regarding vulnerability disclosure. --> This PR implements the Physical Locations table/detail views. It also adds a sidebar and the header service has been converted to a navigation service responsible for both the header and sidebar. AG-Grid is now updated to [version 28](https://blog.ag-grid.com/whats-new-in-ag-grid-28/) allowing for complete Ivy support (no more annoying warnings), among other things. Fixed build warning from obfuscated text component and themes.scss. Also fixes the deprecated notices from ag-grid (not need for upgrade). Modified the generic table context menu _link_ to use the angular router instead of relying on html, this is to prevent page reloads when navigating on the _same_ tab. Also added a resize button to try and fit columns to screen size. Updated the file structure of the nightwatch folder in anticipation of many more e2e tests, which also has the side-effect of making the `page_objects` more type safe. The dev containers for TP/TPv2 have been updated to do a normal `npm install` instead of `npm ci` to more accurately mirror a dev environment, and to not blow away node_modules on the host system. <!-- **^ Add meaningful description above** --><hr/> ## Which Traffic Control components are affected by this PR? <!-- Please delete all components from this list that are NOT affected by this PR. Feel free to add the name of a tool or script that is affected but not on the list. --> - Traffic Portal - CDN in a Box (dev) ## What is the best way to verify this PR? Verify the new pages work and all tests pass. <!-- Please include here ALL the steps necessary to test your PR. If your PR has tests (and most should), provide the steps needed to run the tests. If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. --> <!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch. Examples: - 5.1.2 - 5.1.3 (RC1) --> ## PR submission checklist - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. --> - [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. --> - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. --> - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
