ocket8888 commented on code in PR #7303:
URL: https://github.com/apache/trafficcontrol/pull/7303#discussion_r1089381629
##########
experimental/traffic-portal/src/app/core/cache-groups/regions/table/regions-table.component.ts:
##########
@@ -82,10 +82,9 @@ export class RegionsTableComponent implements OnInit {
];
/** Definitions for the context menu items (which act on augmented
region data). */
- public contextMenuItems: Array<ContextMenuItem<Region>> = [
+ public contextMenuItems: Array<ContextMenuItem<ResponseRegion>> = [
{
- action: "edit",
- multiRow: false,
+ href: (selectedRow: ResponseRegion): string =>
`/core/region/${selectedRow.id}`,
Review Comment:
This path doesn't match any routes. It's `/core/regions/:id`, with an `s`.
That's my fault, I broke that by changing the route (which fixed the previously
broken link on the "+" FAB)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
