shamrickus commented on code in PR #7303:
URL: https://github.com/apache/trafficcontrol/pull/7303#discussion_r1086054580


##########
experimental/traffic-portal/src/app/shared/generic-table/generic-table.component.html:
##########
@@ -49,7 +50,7 @@
        <ul>
                <li *ngFor="let item of contextMenuItems" role="menuitem">
                        <ng-container *ngIf="!isAction(item)">
-                               <a *ngIf="!isDisabled(item)" 
[href]="href(item)" [target]="item.newTab ? '_blank' : 
'_self'">{{item.name}}</a>
+                               <a *ngIf="!isDisabled(item)" 
[href]="href(item)" (click)="clickContextMenu($event, item)" 
[target]="item.newTab ? '_blank' : '_self'">{{item.name}}</a>

Review Comment:
   It still can use the default browser behavior. Regardless, I know of a 
better & easier way of this (way over-engineered this one).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to