ocket8888 commented on code in PR #7750:
URL: https://github.com/apache/trafficcontrol/pull/7750#discussion_r1307696075
##########
lib/go-tc/servers.go:
##########
@@ -1356,7 +1358,9 @@ type ServerV50 struct {
// The time at which revalidations for this server were last updated by
t3c.
RevalApplyTime *time.Time `json:"revalApplyTime"
db:"revalidate_apply_time"`
// The time at which revalidations were last queued for this server.
- RevalUpdateTime *time.Time `json:"revalUpdateTime"
db:"revalidate_update_time"`
+ RevalUpdateTime *time.Time `json:"revalUpdateTime"
db:"revalidate_update_time"`
+ // If the last reval apply failed for this server
+ RevalUpdateFailed *bool `json:"revalUpdateFailed"
db:"revalidate_update_failed"`
Review Comment:
These have a default value; do they need to be reference types? When would
this be `nil`, and what does that mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
