ocket8888 commented on code in PR #7750:
URL: https://github.com/apache/trafficcontrol/pull/7750#discussion_r1309314597
##########
traffic_ops/testing/api/v5/servers_hostname_update_test.go:
##########
@@ -125,9 +137,15 @@ func validateServerApplyTimes(hostName string,
expectedResp map[string]interface
case "ConfigApplyTime":
assert.RequireNotNil(t,
resp.Response[0].ConfigApplyTime, "Expected ConfigApplyTime to not be nil.")
assert.Equal(t, true,
server.ConfigApplyTime.Equal(expected.(time.Time)), "Expected ConfigApplyTime
to be %v, but got %v", expected, server.ConfigApplyTime)
+ case "ConfigUpdateFailed":
+ assert.RequireNotNil(t,
resp.Response[0].ConfigUpdateFailed, "Expected ConfigUpdateFailed to not be
nil.")
Review Comment:
this check cannot possibly fail because non-reference fields can never be
`nil`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
