ocket8888 commented on code in PR #7750:
URL: https://github.com/apache/trafficcontrol/pull/7750#discussion_r1309310745
##########
lib/go-tc/servers.go:
##########
@@ -1437,6 +1441,45 @@ func (s ServerV50) RevalidationPending() bool {
// version 5 of the Traffic Ops API.
type ServerV5 = ServerV50
+type ServerUpdateStatusV5 ServerUpdateStatusV50
+
+type ServerUpdateStatusV50 struct {
+ HostName string `json:"host_name"`
+ UpdatePending bool `json:"upd_pending"`
+ // Deprecated: In APIv5 and later, this extraneous field is not
calculated
+ // by Traffic Ops; the information is available by comparing
RevalUpdateTime
+ // to RevalApplyTime.
Review Comment:
a similar deprecation could be applied to `UpdatePending`
##########
lib/go-tc/servers.go:
##########
@@ -1437,6 +1441,45 @@ func (s ServerV50) RevalidationPending() bool {
// version 5 of the Traffic Ops API.
type ServerV5 = ServerV50
+type ServerUpdateStatusV5 ServerUpdateStatusV50
+
+type ServerUpdateStatusV50 struct {
Review Comment:
These should have GoDoc comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
