rawlinp commented on a change in pull request #1908: Changes for Backup Edge
Cache Group
URL:
https://github.com/apache/incubator-trafficcontrol/pull/1908#discussion_r172585396
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/router/TrafficRouter.java
##########
@@ -675,17 +678,40 @@ public CacheLocation getCoverageZoneCacheLocation(final
String ip, final String
return cacheLocation;
}
- // We had a hit in the CZF but the name does not match a known
cache location.
- // Check whether the CZF entry has a geolocation and use it if
so.
- return
getClosestCacheLocation(cacheRegister.filterAvailableLocations(deliveryServiceId),
networkNode.getGeolocation(),
cacheRegister.getDeliveryService(deliveryServiceId));
+ if (networkNode.getBackupCacheGroups() != null) {
+ for (final String cacheGroup :
networkNode.getBackupCacheGroups()) {
+ final CacheLocation bkCacheLocation =
getCacheRegister().getCacheLocationById(cacheGroup);
+ if (bkCacheLocation != null &&
!getSupportingCaches(bkCacheLocation.getCaches(), deliveryService).isEmpty()) {
+ LOGGER.debug("Got backup CZ cache group
" + bkCacheLocation.getId() + " for " + ip + ", ds " + deliveryServiceId);
+ if (track != null) {
+
track.setFromBackupCzGroup(true);
+ }
+ return bkCacheLocation;
+ }
+ }
+ }
+
+ if (networkNode.isUseClosest()) {
+ // We had a hit in the CZF but the name does not match
a known cache location.
+ // Check whether the CZF entry has a geolocation and
use it if so.
+ final CacheLocation closestCacheLocation =
getClosestCacheLocation(cacheRegister.filterAvailableLocations(deliveryServiceId),
networkNode.getGeolocation(),
cacheRegister.getDeliveryService(deliveryServiceId));
+ if (closestCacheLocation != null) {
+ LOGGER.debug("Got closest CZ cache group " +
closestCacheLocation.getId() + " for " + ip + ", ds " + deliveryServiceId);
+ if (track != null) {
+ track.setFromBackupCzGroup(true);
+ }
+ }
+ return closestCacheLocation;
+ }
+ return null;
Review comment:
I disagree, one of the reasons for specifying backupZones is to confine
traffic to certain cachegroups when the matched cachegroups are unavailable. In
this case we're getting a hit in the CZ (so we know where the client is in the
network), that cachegroup is unavailable, but the client will still fall back
to a Geo-lookup (even though from the CZ-hit we already know where the client
is), best-case scenario get matched to the same cachegroup, find the closest
available cachegroup, and altogether disregard the "confine traffic to certain
cachegroups" rule in the CZF.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
